[FFmpeg-devel] [PATCH] move h264 loopfilter strength code to yasm

[Michael Niedermayer]

On Fri, Sep 24, 2010 at 05:10:35PM -0400, Ronald S. Bultje wrote:
[...]
> -                        "psubw          (%2), %%mm1 \n"
> -                        "psubw         8(%2), %%mm2 \n"
> -                        "psubw       160(%2), %%mm3 \n"
> -                        "psubw       168(%2), %%mm4 \n"
> +                        "psubw          (%3), %%mm1 \n"
> +                        "psubw         8(%3), %%mm2 \n"
> +                        "psubw       160(%3), %%mm3 \n"
> +                        "psubw       168(%3), %%mm4 \n"
>                          "packsswb      %%mm2, %%mm1 \n"
>                          "packsswb      %%mm4, %%mm3 \n"
>                          "paddb         %%mm6, %%mm1 \n"
> @@ -111,26 +111,28 @@
>                          "por           %%mm1, %%mm0 \n"
>                          "pshufw $0x4E, %%mm0, %%mm1 \n"
>                          "pminub        %%mm1, %%mm0 \n"
> -                        ::"r"(d_idx),
> -                          "r"(ref[0]+b_idx),
> -                          "r"(mv[0]+b_idx)
> +                        ::"r"(ref[0]+b_idx),
> +                          "r"(ref[0]+b_idx+d_idx),
> +                          "r"(mv[0]+b_idx),
> +                          "r"(mv[0]+b_idx+d_idx)

this doesnt look correct

and patches should be tested before submitting ideally, i tend to review
based on the assumtion that the code has been tested
(like operands and constraints i dont need to check if they match because
it wouldnt work would they not match)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100924/76d54d22/attachment.pgp>