[FFmpeg-devel] [FFmpeg-cvslog] r25206 - trunk/libavcodec/x86/h264_idct.asm

[Måns Rullgård]

Dave Yeo <daveryeo at telus.net> writes:

> On 09/26/10 05:23 am, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Sep 26, 2010, at 5:15 AM, reimar<subversion at mplayerhq.hu>  wrote:
>>> Author: reimar
>>> Date: Sun Sep 26 11:15:18 2010
>>> New Revision: 25206
>>>
>>> Log:
>>> Add d suffix to movd target register to make it work with nasm.
>>
>> Please add a nasm fate test. (Assuming the nasm patch itself is committed.)
>>
>
> Is not just using nasm to assemble and running make fate a good enough test?
> Testing here with the version of Reimar's patch I posted earlier and a
> new enough version of nasm make fate passes.
> Note that the oldest version that I had archived here that worked is
> NASM version 2.08rc7-20100125 compiled on Jan 25 2010. Nasm 2.07 fails.
> YASM	libavcodec/x86/vc1dsp_yasm.o
> /usr/src/ffmpeg/libavcodec/x86/vc1dsp_yasm.asm:329: error: operation
> size not specified

configure support for nasm is in place.  All that's missing now is the
OS/2 bits.

-- 
M?ns Rullg?rd
mans at mansr.com