[FFmpeg-devel] [RFC] stream parsing

[Michael Niedermayer]

On Sun, Sep 26, 2010 at 10:46:35PM +0200, Benjamin Larsson wrote:
> On 09/26/2010 02:14 PM, Michael Niedermayer wrote:
> > On Sun, Sep 26, 2010 at 12:54:34PM +0200, Benjamin Larsson wrote:
> >>
> >>>
> >>> this looks strange
> >>> i would have expected a
> >>> if((codec->capabilities & CODEC_CAP_CHANNEL_CONF) && !channel_layout)
> >>>     return 0;
> >>>
> >>> in has_codec_parameters()
> >>
> >>
> >> There is no AVCodec available in has_codec_parameters() only an
> >> AVCodecContext.
> > 
> > AVCodecContext.codec
> 
> Yes I know but it is NULL at that time.
> 
> >>
> >> Anyway I redid the patch, it's abit more logical now but pretty much the
> >> same.
> >>
> >> Btw in has_codec_parameters() there is a list of codecs with some
> >> special casing, I think these codecs should have this new capability set.
> > 
> > simplifications is welcome
> > 
> 
> Well if this patch is approved I will submit the additional
> simplifications. So is the patch acceptable ?

the patch looks quite buggy
first AVCodec is something just set to NULL and second once this is fixed
the only thing it will do is never stop aka wait until time or length
thresholds cause av_find_stream_info() to return

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100926/575cad55/attachment.pgp>