[FFmpeg-devel] [PATCH] Move link_dpad and link_spad macros from avfilter.c to internal.h

Stefano Sabatini stefano.sabatini-lala
Mon Sep 27 23:58:01 CEST 2010


On date Monday 2010-09-27 22:42:22 +0200, Michael Niedermayer encoded:
> On Mon, Sep 27, 2010 at 07:31:13PM +0200, Stefano Sabatini wrote:
> > On date Monday 2010-09-27 13:43:08 +0200, Michael Niedermayer encoded:
[..]
> > > > @@ -128,20 +124,22 @@ int avfilter_link(AVFilterContext *src, unsigned srcpad,
> > > >  int avfilter_insert_filter(AVFilterLink *link, AVFilterContext *filt,
> > > >                             unsigned in, unsigned out)
> > > >  {
> > > > +    int dstpad_idx = link->dstpad - link->dst->input_pads;
> > > 
> > > its off topic but i like that name the existing ones should be renamed for
> > > consistency and readability as well
[...]
> >  avfilter.c |   10 +++++-----
> >  avfilter.h |    6 +++---
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> > 7dff125c640fe2af0aa35ff324b54074a6108f3f  0001-Use-longer-and-more-expressive-names-for-the-avfilte.patch
> > From 6c8371d2c03f86d3569af4bb4adfecc772f42653 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Mon, 27 Sep 2010 19:27:10 +0200
> > Subject: [PATCH] Use longer and more expressive names for the avfilter_insert_filter()
> >  in and out parameters.
> 
> should be fine

Applied.
-- 
FFmpeg = Fanciful & Fantastic Miracolous Portable Empowered God



More information about the ffmpeg-devel mailing list