[FFmpeg-devel] [PATCH 4/4] Document url_filesize().

Michael Niedermayer michaelni
Thu Sep 30 12:34:11 CEST 2010


On Thu, Sep 30, 2010 at 12:16:49PM +0200, Stefano Sabatini wrote:
> On date Thursday 2010-09-30 12:43:07 +0300, Martin Storsj? encoded:
> > On Thu, 30 Sep 2010, Stefano Sabatini wrote:
> > 
> > > ---
> > >  libavformat/avio.h |    4 ++++
> > >  1 files changed, 4 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/libavformat/avio.h b/libavformat/avio.h
> > > index 34437bc..0278d8d 100644
> > > --- a/libavformat/avio.h
> > > +++ b/libavformat/avio.h
> > > @@ -184,6 +184,10 @@ int url_close(URLContext *h);
> > >   */
> > >  int url_exist(const char *url);
> > >  
> > > +/**
> > > + * Return the filesize of the resources accessed by h, or a negative
> > > + * value corresponding to an AVERROR error code in case of failure.
> > > + */
> > >  int64_t url_filesize(URLContext *h);
> > 
> > Instead of just "in case of failure", isn't that also returned where it 
> > simply isn't known (even if there is no failure)?
> 
> Yes, it depends on what you intend by "in case of failure". New patch
> should be more clear.
> 
> Regards.
> -- 
> FFmpeg = Faithful Freak Multimedia Powerful Elitist Goblin

>  avio.h |    5 +++++
>  1 file changed, 5 insertions(+)
> 70aae748b9660655ebe9360c431ac89f2a893a45  0004-Document-url_filesize.patch
> From ca314b6cd8246d0c579c226f3d834e8e6a3ed5ab Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sun, 28 Mar 2010 12:19:48 +0200
> Subject: [PATCH 4/4] Document url_filesize().

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100930/157002e1/attachment.pgp>



More information about the ffmpeg-devel mailing list