[FFmpeg-devel] [PATCH+RFC] AVFrame for audio

Michael Niedermayer michaelni
Thu Sep 30 13:24:41 CEST 2010


On Thu, Sep 30, 2010 at 12:56:52PM +0200, Stefano Sabatini wrote:
> On date Thursday 2010-09-30 11:20:22 +0100, M?ns Rullg?rd encoded:
> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > 
> > > On date Wednesday 2010-09-29 21:20:04 -0400, Justin Ruggles encoded:
> [...]
> > >> - adds nb_sample to AVFrame
> > >
> > > <nitpick>
> > > I'd prefer samples_nb. The _nb prefix at the end allows alignment
> > 
> > I had to laugh at "prefix at the end"...
> > 
> > > tricks like:
> > > samples
> > > samples_nb
> > >
> > > Also I read it like:
> > > samples_nb -> samples number
> > > which sounds better than
> > > nb_samples -> number (of) samples
> > 
> > The former sounds rather backwards to me, the latter being perfectly
> > normal English.
> 
> So discard about that, I don't care much anyway.

also
grep '_nb[^a-zA-Z_]' */*.h |wc
      4      34     342
grep '[^a-zA-Z_]nb_' */*.h |wc
     49     306    3532

so its also more consistent

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100930/9f3890ab/attachment.pgp>



More information about the ffmpeg-devel mailing list