[FFmpeg-devel] [PATCH] DVB Subtitles Fix

[JULIAN GARDNER]

--- On Wed, 27/4/11, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> Subject: Re: [FFmpeg-devel] [PATCH] DVB Subtitles Fix
> To: ffmpeg-devel at ffmpeg.org
> Date: Wednesday, 27 April, 2011, 1:08
> JULIAN GARDNER <joolzg <at>
> btinternet.com> writes:
> 
> [...]
> 
> > -             
>                
>       h->rects[object_id]->h >>
> 1);
> > +             
>                
>          
> h->rects[object_id]->h >> 1);
> 
> This looks unrelated / unintended.
> 
> [...]
> 
> > -        if (depth & 0x80)
> > -           
> clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
> 
> > +            if (depth
> & 0x80)
> > +             
>   clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
> 
> Please make your patch smaller (and easier to review) by
> not re-indenting these
> lines.
> 
> Feel free to wait for a real review, Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

So what is the correct way of indenting when code is moved into a new block

so if we had

    if (fred) {
    ...
    }

    yyyy;

and i want yyyy; to be in the if, should i not reindent it to

    if (fred) {
        ....
        yyyy;
    }

joolz