[FFmpeg-devel] [PATCH] lavfi: port mp test source

Stefano Sabatini stefano.sabatini-lala at poste.it
Tue Aug 9 20:59:53 CEST 2011


On date Tuesday 2011-08-09 16:09:47 +0200, Michael Niedermayer encoded:
> On Mon, Aug 08, 2011 at 02:43:15PM +0200, Stefano Sabatini wrote:
> > ---
> >  doc/filters.texi             |   57 ++++++
> >  libavfilter/Makefile         |    1 +
> >  libavfilter/allfilters.c     |    1 +
> >  libavfilter/vsrc_mptestsrc.c |  392 ++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 451 insertions(+), 0 deletions(-)
> >  create mode 100644 libavfilter/vsrc_mptestsrc.c
> 
> if it produces same output
> then ok

After some comparation with showinfo, I had to change M_PI in my code
with 3.141592654, at this point they issue the same output but with
some behavior difference, for mp=test frames with number frame%30 are
skipped, with mptestsrc they are not (which looks more correct).

mp=test tests offset ranges from 1 to 30, for mptestsrc it is from 0
to 29.

Apart from that, the output with the same parameters is exactly the
same with both sources. Are you fine with this?

Should I use the vf_test.c 3.141592654 constant or prefer the more
exact M_PI? (this will change the output)

Let me also know if it is ok to relicense GPL -> LGPL, and if I can
remove the corresponding mp=test code once I commit this.
-- 
FFmpeg = Fast & Fanciful Martial Peaceless Ecletic Governor


More information about the ffmpeg-devel mailing list