[FFmpeg-devel] [PATCH] roqvideodec: Improve checking of input buffer bounds.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Aug 21 17:39:29 CEST 2011


On Sun, Aug 21, 2011 at 03:36:19PM +0200, Michael Niedermayer wrote:
> On Sat, Aug 20, 2011 at 01:14:03PM +0200, Reimar Döffinger wrote:
> > Fixes trac issue #408.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  libavcodec/roqvideodec.c |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c
> > index 4af7ede..bbbb605 100644
> > --- a/libavcodec/roqvideodec.c
> > +++ b/libavcodec/roqvideodec.c
> > @@ -71,9 +71,14 @@ static void roqvideo_decode_frame(RoqContext *ri)
> >      }
> >  
> >      bpos = xpos = ypos = 0;
> > +    chunk_size = FFMIN(chunk_size, buf_end - buf);
> 
> maybe a warning should be printed in case chunk_size changes
> 
> otherwise LGTM

Pushed with that change.


More information about the ffmpeg-devel mailing list