[FFmpeg-devel] [PATCH 1/2] mpegaudiodec: move imdct36() to MPADSPContext

[Michael Niedermayer]

Hi Vitor

On Sun, Aug 21, 2011 at 04:51:48PM +0200, Vitor Sessak wrote:
> $subj, should allow SIMD optimizations.
[...]
>          /* NOTE: we do frequency inversion adter the MDCT by changing
>             the sign of the right window coefs */
>          for(j=0;j<4;j++) {
> -            for(i=0;i<36;i+=2) {

> +            mdct_win[j    ][18] = mdct_win[j    ][19] = 0;
> +            mdct_win[j + 4][18] = mdct_win[j + 4][19] = 0;

these seem unneeded, or maybe i miss something ?


[...]
> @@ -1403,15 +1294,15 @@ static void compute_imdct(MPADecodeContext *s,
>          else
>              win1 = mdct_win[g->block_type];
>          /* select frequency inversion */
> -        win = win1 + ((4 * 36) & -(j & 1));
> -        imdct36(out_ptr, buf, ptr, win);
> +        win = win1 + ((4 * 40) & -(j & 1));
> +	s->mpadsp.RENAME(imdct36)(out_ptr, buf, ptr, win);

tabs


[...]
> +/* using Lee like decomposition followed by hand coded 9 points DCT */
> +void RENAME(ff_imdct36)(INTFLOAT *out, INTFLOAT *buf, INTFLOAT *in, 

trailing whitespace

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110821/f2cc39d0/attachment.asc>