[FFmpeg-devel] [PATCH] Revert "oggdec:Correct duration"

Michael Niedermayer michaelni at gmx.at
Wed Aug 24 23:33:46 CEST 2011

Hi Andrew

On Wed, Aug 24, 2011 at 11:47:45AM -0400, Andrew Scherkus wrote:
> Hello,
> We got some Chromium bug reports about incorrect ogg durations last
> time we updated FFmpeg. I traced it back to 5901cd6... which was
> applied from an old patch from ffmpeg2theora.
> It looks like someone else had already made a similar fix in
> 44a088e... which means that applying both patches made for incorrect
> duration calculations.

Well, yes and no, the original code only works when that skeleton stuff
is in the file which seems not that common.

You can try the file at
to convince yourself that the old code does not solve it and the
2nd case is needed

Now:                Duration: 00:01:00.34
with your patch:    Duration: 13:27:30.26
outputed wav:       Duration: 00:01:00.60

Either way there are several bugs in this code, ill try to fix this in
a moment but i dont have a idea for a really pretty fix.
better ideas / commits definitly welcome

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110824/34c5b29c/attachment.asc>

More information about the ffmpeg-devel mailing list