[FFmpeg-devel] [PATCH] Revert "oggdec:Correct duration"

[Andrew Scherkus]

On Wed, Aug 24, 2011 at 5:33 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>
> Hi Andrew
>
> On Wed, Aug 24, 2011 at 11:47:45AM -0400, Andrew Scherkus wrote:
> > Hello,
> >
> > We got some Chromium bug reports about incorrect ogg durations last
> > time we updated FFmpeg. I traced it back to 5901cd6... which was
> > applied from an old patch from ffmpeg2theora.
> >
> > It looks like someone else had already made a similar fix in
> > 44a088e... which means that applying both patches made for incorrect
> > duration calculations.
>
> Well, yes and no, the original code only works when that skeleton stuff
> is in the file which seems not that common.
>
> You can try the file at
> http://code.google.com/p/gnome-mplayer/issues/detail?id=300
> to convince yourself that the old code does not solve it and the
> 2nd case is needed
>
> Now:                Duration: 00:01:00.34
> with your patch:    Duration: 13:27:30.26
> outputed wav:       Duration: 00:01:00.60
>
> Either way there are several bugs in this code, ill try to fix this in
> a moment but i dont have a idea for a really pretty fix.
> better ideas / commits definitly welcome

Thanks for the test case!

I had a couple strange ogg files that were reported via the Chromium
bug tracker that my patch seemed to fix, but I wasn't able to find a
test case for the original patch to verify that nothing regressed.

Re: patch formatting -- I tried to use gmail w/o rich formatting but
that apparently didn't work out so well. Might have to try attachments
next time around.

Thanks,
Andrew