[FFmpeg-devel] Subject: [PATCH] Process compressed id3v2 tags.

Adrian Drzewiecki adrian.drzewiecki at gmail.com
Sat Dec 3 20:22:03 CET 2011


On Dec 3, 2011, at 11:14 AM, Reimar Döffinger wrote:

> On Sat, Dec 03, 2011 at 10:46:46AM -0800, Adrian Drzewiecki wrote:
>> +            char *type;
> 
> "const char *" is more correct.

Good point.

> 
>> +                for (i = 0, j = 0; i < dlen; i++, j++) {
>> +                    if (tcomp)
>> +                        buffer[j] = avio_r8(s->pb);
> 
> Did you test this to work? Because I'm quite convinced this should be
> "!tcomp"...

Ugh. I could have sworn I did!!! You're right in that this is wrong.
Sorry. Will repost.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



More information about the ffmpeg-devel mailing list