[FFmpeg-devel] [PATCH] lavd/lavfi: fix two memleaks.

[Michael Niedermayer]

On Thu, Dec 15, 2011 at 07:51:38PM +0100, Nicolas George wrote:
>
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavdevice/lavfi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> index 04dc3b2..cd73234 100644
> --- a/libavdevice/lavfi.c
> +++ b/libavdevice/lavfi.c
> @@ -71,6 +71,7 @@ av_cold static int lavfi_read_close(AVFormatContext *avctx)
>
>      av_freep(&lavfi->sink_stream_map);
>      av_freep(&lavfi->stream_sink_map);
> +    av_freep(&lavfi->sinks);
>      avfilter_graph_free(&lavfi->graph);
>
>      return 0;

ok

> @@ -252,6 +253,7 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx,
>      }
>
>  end:
> +    av_free(pix_fmts);

this might lead to use after free in sink_buffer.c if iam not misssing
anything

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111216/7cea658a/attachment.asc>