[FFmpeg-devel] [PATCH] ffprobe: add show_private_data option

[Clément Bœsch]

On Thu, Dec 22, 2011 at 02:14:03PM +0100, Stefano Sabatini wrote:
> On date Thursday 2011-12-22 12:34:03 +0100, Clément Bœsch encoded:
> > On Thu, Dec 22, 2011 at 11:09:48AM +0100, Stefano Sabatini wrote:
> > > ---
> > >  doc/ffprobe.texi |    6 ++++++
> > >  ffprobe.c        |    5 ++++-
> > >  2 files changed, 10 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi
> > > index 89b270d..d75c251 100644
> > > --- a/doc/ffprobe.texi
> > > +++ b/doc/ffprobe.texi
> > > @@ -115,6 +115,12 @@ multimedia stream.
> > >  Each media stream information is printed within a dedicated section
> > >  with name "STREAM".
> > >  
> > > + at item -show_private_data, -private
> > > +Show private data, that is data depending on the format of the
> > > +particolar shown element.
> > 
> > particular
> > 
> > > +This option is enabled by default, but you may need to disable it
> > > +for specific uses, for example when creating XSD-compliant XML output.
> > > +
> > 
> > Won't it be disabled by default with XML?
> 
> I don't know, right now in my local XML patch I have:
> 
>     if (xml->fully_qualified) {
> #define WARN_COMPLIANCE(opt, opt_name)                                  \
>         if (opt) {                                                      \
>             av_log(wctx, AV_LOG_WARNING,                                \
>                    "Fully qualified output selected but option '%s' was selected, XML output may be non-compliant.\n" \
>                    "You may need to disable such option with '-no%s'\n", opt_name, opt_name); \
>         }
>         WARN_COMPLIANCE(show_private_data, "private");
>         WARN_COMPLIANCE(show_value_unit,   "unit");
>         WARN_COMPLIANCE(use_value_prefix,  "prefix");
>     }
> 
> I suppose someone may want to show those values anyway, even if q=1
> was specified. A possible alternative: force private=0, unit=0,
> prefix=0 when fully qualified option is specified *by default*, or add
> another option strict to the xml writer (xml=q=1:strict=1) which
> forces private=0,unit=0,prefix=0 (possibly warning the user about the
> option override).
> 

OK, that should be discussed in the XML patch anyway.

> Anyway I believe -private should be enabled by default

Yes sure. I don't have any objection on the patch, my question was out of
curiosity.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111222/7565ffa9/attachment.asc>