[FFmpeg-devel] [PATCH]Do not fail decoding invalid v410 files

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Dec 30 01:57:19 CET 2011


On 30 Dec 2011, at 00:11, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Derek Buitenhuis <derek.buitenhuis <at> gmail.com> writes:
> 
>>> -    if (avctx->width&  1) {
>>> -        av_log(avctx, AV_LOG_ERROR, "v410 requires width to be even.\n");
>>> -        return AVERROR_INVALIDDATA;
>>> -    }
>>> -
>>>      avctx->coded_frame = avcodec_alloc_frame();
>>> 
>>>      if (!avctx->coded_frame) {
>> 
>> I am not sure I like this at all. The spec says they HAVE to be
>> even widths. I don't like the idea of opening the possibility of
>> side effects simply to support invalid files.
> 
> It has always been FFmpeg policy to DEcode invalid files if possible.

complaining about them if they are clearly invalid is a good idea though.


More information about the ffmpeg-devel mailing list