[FFmpeg-devel] [PATCH 3/3] flvdec: Print a warning in all failure cases of parse_keyframes_index()

Michael Niedermayer michaelni at gmx.at
Fri Dec 30 03:57:40 CET 2011


On Thu, Dec 29, 2011 at 07:54:33PM -0500, Derek Buitenhuis wrote:
> On 29/12/2011 7:38 PM, Michael Niedermayer wrote:
> >Signed-off-by: Michael Niedermayer<michaelni at gmx.at>
> >---
> >  libavformat/flvdec.c |    8 +++++---
> >  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> I dislike goto's but I see nothing wrong with this.
> Pretty straightforward.

noone likes gotos, me neither

applied and thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111230/46ac01c3/attachment.asc>


More information about the ffmpeg-devel mailing list