[FFmpeg-devel] [PATCH] Implement guessed_pts in avcodec_decode_video2.

Michael Niedermayer michaelni
Tue Feb 1 21:29:59 CET 2011


On Tue, Feb 01, 2011 at 09:09:21PM +0100, Nicolas George wrote:
> Le tridi 13 pluvi?se, an CCXIX, M?ns Rullg?rd a ?crit?:
[...]
> > The problem with the current approach is that perfectly good
> > timestamps (e.g. from mkv files) are misdetected as wrong and "fixed",
> > resulting in the notorious non-monotone timestamps error, among other
> > problems.
> 
> Do you have a pointer to sample for this case? I do not think that the
> guessing algorithm we are discussing right now can lead to non-monotone
> timestamps on valid files.

i dont think mans has read the code he argues about ...


> 
> > Any automatic tampering with timestamps should be conservative, only
> > kicking in when things are obviously wrong, such as two frames with
> > the same PTS stored in the container.  We have to assume files are
> > correct by default, and enable aggressive fixups only after being
> > explicitly requested.
> 
> I think the algorithm we are discussing in this thread is conservative: it
> only selects one among the actual PTS and DTS: if only one is present, of if
> both are present and valid (and therefore equals), it just outputs them.

see above, and as said ive no interrest in this discussion, there are people
with whom you cannot disucuss, lets just agree he is
correct and ignore him.
Ill look into this and apply it to videolan if its ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110201/cccf144a/attachment.pgp>



More information about the ffmpeg-devel mailing list