[FFmpeg-devel] [PATCH] Separate format conversion DSP functions from DSPContext.

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Tue, Feb 1, 2011 at 6:13 PM, Mans Rullgard <mans at mansr.com> wrote:
>> From: Justin Ruggles <justin.ruggles at gmail.com>
>>
>> This will be beneficial for use with the audio conversion API without
>> requiring it to depend on all of dsputil.
>
> I had a quick look at the x86 SIMD, nothing particularly wrong with it.
>
>> +    mov src1q, [srcq+1*gprsize]
>> +    mov src2q, [srcq+2*gprsize]
>> +    mov src3q, [srcq+3*gprsize]
>> +    mov src4q, [srcq+4*gprsize]
>> +    mov src5q, [srcq+5*gprsize]
>
> Why do you use the "q" variant of registers? Shouldn't you use the "q"
> for x86-64 and "d" for x86-32? Or is "q" automatically "degraded" to
> "d" on x86-32?

That code is just moved from one file to another.  I believe the
original was written by Loren.

-- 
M?ns Rullg?rd
mans at mansr.com