[FFmpeg-devel] [PATCH 0/2] Origin Wing Commander IV video decoder

[Diego Biurrun]

On Thu, Feb 03, 2011 at 01:28:23PM +0100, Benoit Fouet wrote:
> On Thu, 03 Feb 2011 12:30:17 +0100 Diego Biurrun wrote:
> > On Thu, Feb 03, 2011 at 10:32:25AM +0100, Kostya wrote:
> > > +static int xan_unpack_luma(const uint8_t *src, int src_size, uint8_t *dst, int dst_size)
> > 
> > Long line; src_size and dst_size should be const.
> > 
> > > +   uint8_t *dst_end = dst + dst_size;
> > > +   const uint8_t *src_end = src + src_size;
> > 
> > dst_end should be const as well.
> > 
> > > +/* almost the same as in xan_wc3 decoder */
> > > +static int xan_unpack(uint8_t *dest, int dest_len, const uint8_t *src, int src_len)
> > 
> > Long line; dest_len and src_len should be const.
> 
> There is very little point in having them const.  Could you clarify why
> you want them to be?

I'm somewhat surprised by your question - because they are not changed
inside the function?  Was there ever another reason to declare something
const?

Diego