[FFmpeg-devel] [PATCH 2/2] Add sample_aspect_ratio fields to vsrc_buffer arguments. This fixes aspect handling in ffmpeg This is based on a patch by baptiste

[Stefano Sabatini]

On date Thursday 2011-02-03 22:39:24 -0500, Ronald S. Bultje encoded:
> Hi,
> 
> On Thu, Feb 3, 2011 at 7:16 PM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
> > On date Thursday 2011-02-03 16:42:29 -0500, Mike Scheutzow encoded:
[...]
> >> Command line argument ordering is already very complicated in
> >> ffmpeg. We shouldn't make it even more difficult to get the desired
> >> output file.
> >>
> >> One solution is to have -vf abort (with a good error message) if
> >> 'vfilters' is already non-null.
> >
> > Simpler variant of this, forces the user to use setdar if libavfilter
> > is enabled.
> [..]
> > @@ -2825,6 +2835,11 @@ static void opt_frame_pix_fmt(const char *arg)
> >
> >  static void opt_frame_aspect_ratio(const char *arg)
> >  {
> > +#if CONFIG_AVFILTER
> > +    av_log(NULL, AV_LOG_ERROR,
> > +           "Option 'aspect' is incompatible with filters, use the setdar filter instead\n");
> > +    ffmpeg_exit(1);
> > +#else
> >      int x = 0, y = 0;
> >      double ar = 0;
> >      const char *p;
> 
> Uhm, maybe a little more explicit (-vf "bla bla") would help the more
> non-developer users. But in general I'm OK with this.

More explicit, updated.

Note to the committer: update version number and APIchanges.
-- 
FFmpeg = Fierce Faithful Murdering Perennial Ecumenical God