[FFmpeg-devel] [PATCH 2/2] cmdutils: fix codec-specific options from preset

Ronald S. Bultje rsbultje
Sun Feb 6 00:35:26 CET 2011


Hi,

On Fri, Feb 4, 2011 at 9:29 PM, James Zern <jzern at google.com> wrote:
> On Fri, Feb 4, 2011 at 18:00, James Zern <jzern at google.com> wrote:
>> Using a preset file caused the address of a stack variable to be stored
>> in opt_names/values. This change causes the strings to be dup'd then
>> freed in uninit_opts.
>> ---
>> ?cmdutils.c | ? 12 ++++++++++--
>> ?1 files changed, 10 insertions(+), 2 deletions(-)
>>
> Meant to include a diff with a comment concerning the frees.

I have to admit this is kind of ugly, but it fixes a clear bug.
Michael, Stefano, if you have objections please raise them, queued for
now.

Ronald



More information about the ffmpeg-devel mailing list