[FFmpeg-devel] [PATCH 2/6] Frame-based multithreading framework using pthreads

[Ronald S. Bultje]

Hi,

On Sun, Feb 6, 2011 at 4:02 AM, Alexander Strange <astrange at ithinksw.com> wrote:
> On Feb 5, 2011, at 10:05 PM, Ronald S. Bultje wrote:
>> Also, if you set n_threads to 1000 on a codec without threading
>> support, it seems like it'll allocate 1000 slice-threads, which then
>> do nothing? I know it did that before also. Should that be fixed, e.g.
>> by introducing a CODEC_CAP_SLICE_THREADS? (In a future commit, not
>> this one.)
>
> Yeah, but is that a problem? 1000 is too many threads if the codec does support it.
>
> I'd like to come back and make the slice threads only start when execute()/execute2()
> are called. Setting -threads in ffmpeg makes it start the same number of slice threads
> for the audio codec and encoders, when they don't always use them, and that clutters
> up debugger backtraces a little.

Well that's what I meant, it's a waste of resources. (Is now, still is
with your patch, so don't worry about it too much for now, but should
be cleaned up eventually at some point by someone.

Ronald