[FFmpeg-devel] [PATCH 2/2] Add sample_aspect_ratio fields to vsrc_buffer arguments. This fixes aspect handling in ffmpeg This is based on a patch by baptiste

[Michael Niedermayer]

On Mon, Feb 07, 2011 at 11:37:43AM +0100, Stefano Sabatini wrote:
> On date Sunday 2011-02-06 16:17:59 +0100, Michael Niedermayer encoded:
> > On Sun, Feb 06, 2011 at 04:03:56PM +0100, Stefano Sabatini wrote:
> > > On date Sunday 2011-02-06 00:26:17 +0100, Michael Niedermayer encoded:
> [...]
> > > > dont forget to test that your cases get aspects both on init time as well as
> > > > per frame time correct
> > > 
> > > I don't think this was never supported, so I'd rather skip it for now
> > > (which should be addressed by filtegraph dynamic reconfiguration).
> > 
> > it works in ffmpeg at videolan except for the stream copy case where one of the
> > 2 is wrong but it was wrong before libavfilter there too according to my tests.
> > And yes i do test before pushing changes
> > 
> > If you send patches against videolan i can help you think about how to fix the
> > remaining issues there. But with patches against ffmpeg.org its less work for
> > me to fix it myself in videolan and ignore what is submitted here because you
> > work on a basis that is much buggier and these are bugs ive fixed already.
> 
> So I suggest to apply the patches as committed to ffmpeg at videolan, and
> from there fix both repos at the same time, having to fix one single
> codebase is enough for me.

People have to work against the repository of the file maintainer. Thats
ffmpeg at videolan for all things i maintain currently.
This problem will reoccur with every patch, you cant wait until things hit
ffmpeg.org

But theres no need to discuss this, you can just try to work against ffmpeg.org
or a branch there to see why this isnt working

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110207/972658fb/attachment.pgp>