[FFmpeg-devel] [PATCH] Vorbis-in-Ogg: Do not set timebase to invalid values

[Reimar Döffinger]

On Mon, Feb 07, 2011 at 03:49:45PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 07, 2011 at 09:34:53AM -0500, Justin Ruggles wrote:
> > >>>> 1) Why is anything in libavformat setting codec->time_base for decoders
> > >>>> when the documentation says that's supposed to be done by libavcodec
> > >>>> ("decoding: Set by libavcodec.")?
> > >>>
> > >>> Because the docs are buggy
> > > 
> > > here the docs should be fixed

> > I just didn't understand what you were saying. "the docs are buggy" and
> > "leave the documentation" seems contradictory and didn't really answer
> > my questions as to the best way to move forward.  My best guess is:
> > 
> > 1) change time_base documentation to say "decoding: Set by user if
> > known, overridden by libavcodec if known"
> 
> exactly

Uh, that does not fix the original issue. codec->time_base is set
by libavformat. That still contradicts that description.
What is the point of (AFAICT) some demuxers setting only stream->time_base
others setting stream->codec->time_base and others setting both (to the same value)?