[FFmpeg-devel] [PATCH] CrystalHD decoder support v4

Philip Langdale philipl
Tue Feb 8 06:34:20 CET 2011


On Mon, 07 Feb 2011 13:01:58 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> Some nitpicks from me below.  Fixing them would be appreciated, but
> don't bother sending a fresh patch just for them.

I've fixed everything that was fixable.

> Also, CamelCase is ugly.

While it's fine to feel that way, CamelCase is clearly the
standard throughout the codebase. eg: AVCodecContext.
 
> > +static inline void memcpy_pic(void *dst, const void *src,
> > +                              int bytesPerLine, int height,
> > +                              int dstStride, int srcStride)
> > +{
> > +    int i;
> > +    for (i = 0; i < height; i++) {
> > +        memcpy(dst, src, bytesPerLine);
> > +        src = (const uint8_t*)src + srcStride;
> > +        dst = (uint8_t*)dst + dstStride;
> > +    }
> > +}
> 
> Question for the audience: Don't we have something like that already?

This came from mplayer; that might be what you're thinking of. I haven't
found anything like it in ffmpeg.
 
Thanks,

--phil



More information about the ffmpeg-devel mailing list