[FFmpeg-devel] [PATCH 11/11] Make inter_rvlc and intra_rvlc static tables.

[Diego Biurrun]

On Sun, Feb 06, 2011 at 09:54:21AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Feb 6, 2011 at 9:47 AM, Diego Elio Petten? <flameeyes at gmail.com> wrote:
> > Il giorno mar, 25/01/2011 alle 10.53 -0500, Ronald S. Bultje ha scritto:
> >>
> >> Doesn't this duplicate the tables in each file? Please extern them and
> >> then define them in a .c file instead.
> >
> > Fun times ahead! Your grep was reporting not "mpeg4data.h" but
> > "msmpeg4data.h" as well:
> [..]
> 
> Oh, right, ok, patch is fine then.
> 
> > I guess another alternative would be to move the whole definition of
> > those two tables into mpeg4videodec.c so that they are fully static
> > there.
> 
> Nah, we always put tables in .h files. Keeps .c files nice and clean.

We have some tables in .c files...

Diego