[FFmpeg-devel] [PATCH 0/3] Make ff_probe_input_buffer public (+ trivial fixes)

Tomas Härdin tomas.hardin
Tue Feb 8 19:11:17 CET 2011


Ronald S. Bultje skrev 2011-02-08 18:24:
> Hi,
>
> On Mon, Feb 7, 2011 at 5:46 PM, Anssi Hannula<anssi.hannula at iki.fi>  wrote:
>> Currently applications that hand over data to lavf via a ByteIOContext
>> (like XBMC) can't initiate a full probe on the ByteIOContext. Instead
>> they have to pretty much duplicate the code of ff_probe_input_buffer
>> (which is also difficult as it uses ff_rewind_with_probe_data()) for no
>> good reason that I can see.
>>
>> Change that by making ff_probe_input_buffer public.
>>
>> There are also 2 trivial patches to ff_probe_input_buffer in this set.
>>
>> Anssi Hannula (3):
>>       lavf: update ff_probe_input_buffer documentation
>>       lavf: simplify pb parameter of ff_probe_input_buffer
>>       lavf: rename ff_probe_input_buffer to make it public
>> ---
>>   doc/APIchanges         |    4 ++++
>>   libavformat/avformat.h |   19 +++++++++++++++++++
>>   libavformat/internal.h |   19 -------------------
>>   libavformat/utils.c    |    8 ++++----
>>   libavformat/version.h  |    2 +-
>>   5 files changed, 28 insertions(+), 24 deletions(-)
>
> I've had a look at this yesterday and it sounds OK to me. Anyone else
> have opinions? I'll queue this later today if I hear nothing.

LGTM

/Tomas



More information about the ffmpeg-devel mailing list