[FFmpeg-devel] Possible bug in dvbsub.c

[Måns Rullgård]

Ronen Mizrahi <ronen at tversity.com> writes:

> Hello,
>
> Looks like line 226 in dvbsub.c is neglecting to put the object version in
> the correct bits:
> *q++ = s->object_version | (page_state << 2) | 3;
>
> It should be:
>
> *q++ = (s->object_version << 4) | (page_state << 2) | 3;

That certainly _looks_ more reasonable.  Care to prepare a proper patch?

> I am no dvbsub expert so I was hoping someone on the list can confirm. In my
> case the encoding did not play correctly in vlc before this patch but does
> after it, so I suspect it is indeed required.

Which spec covers this?  Shouldn't be hard to verify the fix against spec.

-- 
M?ns Rullg?rd
mans at mansr.com