[FFmpeg-devel] [PATCH 01/10] lavf: move ff_guidcmp from asfdec.c to asf.c

Måns Rullgård mans
Tue Feb 8 23:03:14 CET 2011


Diego Elio Petten? <flameeyes at gmail.com> writes:

> Il giorno mar, 08/02/2011 alle 21.00 +0000, M?ns Rullg?rd ha scritto:
>> 
>> Why is this a function at all, and why is it in asf.c?  If calling
>> memcmp directly is too much trouble, I'd at make it a macro instead. 
>
> Let's remember that while inlining has overhead, exposing new symbols
> has its share of overhead as well, especially as long as we don't hide
> internal symbols.

Inlining of that particular function has negative overhead.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list