[FFmpeg-devel] [PATCH 09/10] asfdec: remove some commented-out debugging garbage

Anton Khirnov anton
Wed Feb 9 19:54:36 CET 2011


On Wed, Feb 09, 2011 at 01:38:25PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Feb 9, 2011 at 12:44 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Tue, Feb 08, 2011 at 09:46:54PM +0100, Anton Khirnov wrote:
> >> @@ -701,8 +692,6 @@ static int asf_read_header(AVFormatContext *s, AVFormatParameters *ap)
> >> ? ? ? ? ? ? ? ? ? ? ? ? ? ?&st->sample_aspect_ratio.den,
> >> ? ? ? ? ? ? ? ? ? ? ? ? ? ?asf->dar[0].num, asf->dar[0].den, INT_MAX);
> >>
> >> -//av_log(s, AV_LOG_INFO, "i=%d, st->codec->codec_type:%d, dar %d:%d sar=%d:%d\n", i, st->codec->codec_type, dar[i].num, dar[i].den, st->sample_aspect_ratio.num, st->sample_aspect_ratio.den);
> >> -
> >> ? ? ? ? ? ? ?// copy and convert language codes to the frontend
> >> ? ? ? ? ? ? ?if (asf->streams[i].stream_language_index < 128) {
> >> ? ? ? ? ? ? ? ? ?const char *rfc1766 = asf->stream_languages[asf->streams[i].stream_language_index];
> >
> > Some could probably easily and with little effort be converted
> > to av_dlog, but I don't really mind.
> 
> I was actually thinking the same thing, av_dlog() would be great.
Well separating those that might be useful from those that won't and
prettifying it seems more effort than it's worth.
(I always find it easier to just add my own av_logs()s)

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110209/a63f3524/attachment.pgp>



More information about the ffmpeg-devel mailing list