[FFmpeg-devel] [PATCH] mov tkhd' width and height usage

Benjamin Larsson banan
Thu Feb 10 15:12:39 CET 2011


On 02/06/2011 09:27 AM, Maksym Veremeyenko wrote:
> Baptiste Coudurier ???????(??):
>> On 01/28/2011 06:31 AM, Maksym Veremeyenko wrote:
> [...]
>>> i updated a patches.
>>>
>>> *pasp* atom did not affect quicktime player in my case, so the proper
>>> solution is add *clef* atom that really affect player....
>>>
>>>
>>>
>>> 0001-move-visual-presentation-dims-apertures-from-tkhd-to.patch
> [...]
>>> +static int mov_write_clef_tag(ByteIOContext *pb, MOVTrack *track)
>>> +{
>>> +    int32_t width;
>>> +    double sample_aspect_ratio;
>>> +
>>> +    sample_aspect_ratio = av_q2d(track->enc->sample_aspect_ratio);
>>> +
>>> +    if(!sample_aspect_ratio || track->height != track->enc->height)
>>> +        sample_aspect_ratio = 1;
>>
>> In that you must not write the atom.
>>
>> Let me check the situation first.
>>
>
> any news?
>

clef and enof should be written. Flip writes those atoms. There is
another patch on the mailinglist to use these atoms for DAR and PAR
calculation. It would make sense to merge both of these patches.

MvH
Benjamin Larsson



More information about the ffmpeg-devel mailing list