[FFmpeg-devel] [PATCH 2/2] mmst: don't look for a hr field in ping messages

Ronald S. Bultje rsbultje
Sun Feb 13 22:40:34 CET 2011


Hi,

On Sun, Feb 13, 2011 at 4:20 PM, Diego Elio Petten? <flameeyes at gmail.com> wrote:
> Il giorno sab, 12/02/2011 alle 16.45 -0500, Ronald S. Bultje ha scritto:
>>
>> + ? ? ? ? ? ?if (read_result >= 44) {
>> + ? ? ? ? ? ? ? ?hr = AV_RL32(mms->in_buffer + 40);
>> + ? ? ? ? ? ? ? ?if (hr) {
>
> LGTM
>
> <bikeshedding>
> although I would have used a single
> if ( (read_result >= 44 ) && (hr = AVRL_ ...
> </bikeshedding>

Fine, attached.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mmst-fix-reading-uninitialized-data-for-ping-packets.patch
Type: application/octet-stream
Size: 1037 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110213/8ca83eb2/attachment.obj>



More information about the ffmpeg-devel mailing list