[FFmpeg-devel] [PATCH] samplefmt: add missing include.

Stefano Sabatini stefano.sabatini-lala
Thu Feb 17 15:20:20 CET 2011


On date Thursday 2011-02-17 13:42:18 +0100, Janne Grunau encoded:
> On Thu, Feb 17, 2011 at 12:34:27PM +0000, M?ns Rullg?rd wrote:
> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > 
> > > Add missing inclusion of "avutil.h" to samplefmt.h. This is required,
> > > to make the header usable without the explicit inclusion of further
> > > headers in files using it.
> > > ---
> > >  libavutil/samplefmt.h |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h
> > > index 0604580..9739d77 100644
> > > --- a/libavutil/samplefmt.h
> > > +++ b/libavutil/samplefmt.h
> > > @@ -19,6 +19,8 @@
> > >  #ifndef AVUTIL_SAMPLEFMT_H
> > >  #define AVUTIL_SAMPLEFMT_H
> > >
> > > +#include "avutil.h"
> > > +
> > 
> > Why?  I don't see anything in samplefmt.h referencing anything defined
> > in avutil.h.
> 
> indeed, make checkheaders passes too without this change, dropped

ah ok, I needed the patch for the audio-filters branch with the
av_samples_* functions which use uint8_t, I thought that including
"avutil.h" was a good idea anyway, though the patch can be safely
dropped.
-- 
FFmpeg = Fostering and Foolish Mastodontic Pacific Elegant Gospel



More information about the ffmpeg-devel mailing list