[FFmpeg-devel] [PATCH] aacenc: remove the data arrays

Alex Converse alex.converse
Fri Feb 18 11:26:25 CET 2011


On Thu, Feb 17, 2011 at 11:28 PM, Young Han Lee <cpumaker at gmail.com> wrote:
> Hello
>

Hi

> On Fri, Feb 18, 2011 at 1:32 PM, Nathan Caldwell <saintdev at gmail.com> wrote:
>
>> LGTM. Would like to hear what Alex has to say about it.
>>

I'm pretty neutral on this. I'm not particularly keen on prematurely
obfuscating the code base unless there is some sort of speed up
associated with it that could help with development.

OTOH there doesn't seem to be any real harm here and it gets some crud
out of the context.

>> Just curious, what's the reason for this? To cut down on memory usage?
>>
>>
> Yes, it is for cutting down on memory usage.
> Also curious to me.
> Does the memory optimization have less priority on FFmpeg?
>

Keeping memory use in check can be important particularly from a cache
perspective.

Regards,
Alex



More information about the ffmpeg-devel mailing list