[FFmpeg-devel] [PATCH 04/10] avio: rename ByteIOContext->AVIOContext

Ronald S. Bultje rsbultje
Sat Feb 19 16:15:21 CET 2011


Hi,

On Sat, Feb 19, 2011 at 10:04 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Feb 19, 2011 at 12:42:48PM +0100, Anton Khirnov wrote:
[..]
>> ?140 files changed, 868 insertions(+), 864 deletions(-)
>>
>> diff --git a/ffserver.c b/ffserver.c
>> index 7a16b2d..c2563b7 100644
>> --- a/ffserver.c
>> +++ b/ffserver.c
>> @@ -163,7 +163,7 @@ typedef struct HTTPContext {
>>
>> ? ? ?/* RTSP state specific */
>> ? ? ?uint8_t *pb_buffer; /* XXX: use that in all the code */
>> - ? ?ByteIOContext *pb;
>> + ? ?AVIOContext *pb;
>> ? ? ?int seq; /* RTSP sequence number */
>
> The context has nothing to do with audio & video input/output.
> I support ByteIOContext getting a prefix but not to remove the "Byte" part

AVByteIOContext is fine, avbyteio_*() is not ideal (IMO), too long.
Are you OK with avio_*() along with AVByteIOContext?

Also, what about URLContext? AVUrlContext OK or would you prefer
something else? And for functions, is av_url_*() OK? (And then,
likely, url_f*() will be renamed to avio_*().)

Ronald



More information about the ffmpeg-devel mailing list