[FFmpeg-devel] [PATCH] Remove old VCSs from version.sh

Diego Biurrun diego
Tue Feb 22 20:20:27 CET 2011


On Mon, Feb 21, 2011 at 02:05:24AM -0800, Alex Converse wrote:
> On Mon, Feb 21, 2011 at 1:50 AM, Reinhard Tartler <siretart at tauware.de> wrote:
> > On Mon, Feb 21, 2011 at 09:07:10 (CET), Alex Converse wrote:
> >
> >> --- a/version.sh
> >> +++ b/version.sh
> >> @@ -1,21 +1,5 @@
> >> ?#!/bin/sh
> >>
> >> -# check for SVN revision number
> >> -revision=$(cd "$1" && cat snapshot_version 2> /dev/null)
> >
> > Please keep support for the 'snapshot_version' file. It is used to
> > specify the version number for out-of-vcs builds.
> 
> Can you give an example of where this snapshot_version is currently used?
> 
> The original documentation for snapshot_version says:
> 
> Read revision string from the file snapshot_version if available.
> This will be used by daily snapshots without Subversion metadata.
> 
> It is in the group of revision probes that get prefixed with SVN-r
> which implies that if it is still used it is at best wrong.

I used that in my script that built nightly tarballs.  Yes, it is badly
in need of an update and this code will need to get fixed, but leave it
anyway for now.

Diego



More information about the ffmpeg-devel mailing list