[FFmpeg-devel] [PATCH 07/16] vmdaudio: use macros and a local variable for block type.

Reimar Döffinger Reimar.Doeffinger
Tue Feb 22 23:23:31 CET 2011


On Tue, Feb 22, 2011 at 03:34:16PM -0500, Justin Ruggles wrote:
> On 02/22/2011 02:30 PM, Reimar D?ffinger wrote:
> 
> > On Tue, Feb 22, 2011 at 02:05:26PM -0500, Justin Ruggles wrote:
> >> ---
> >>  libavcodec/vmdav.c |   13 ++++++++++---
> >>  1 files changed, 10 insertions(+), 3 deletions(-)
> >>
> > 
> >> diff --git a/libavcodec/vmdav.c b/libavcodec/vmdav.c
> >> index ed3c5f8..0a77d37 100644
> >> --- a/libavcodec/vmdav.c
> >> +++ b/libavcodec/vmdav.c
> >> @@ -414,6 +414,10 @@ static av_cold int vmdvideo_decode_end(AVCodecContext *avctx)
> >>   * Audio Decoder
> >>   */
> >>  
> >> +#define BLOCK_TYPE_AUDIO    1
> >> +#define BLOCK_TYPE_INITIAL  2
> >> +#define BLOCK_TYPE_SILENCE  3
> > 
> > Why not an enum?
> 
> 
> I thought about it. Not much difference really.

No, just gives the option of using the enum type for better
code clarity or so, as you want.



More information about the ffmpeg-devel mailing list