[FFmpeg-devel] [PATCH] movenc: convert put_tag() into ffio_wfourcc().

Michael Niedermayer michaelni
Sat Feb 26 11:03:18 CET 2011


On Fri, Feb 25, 2011 at 04:10:26PM -0800, Baptiste Coudurier wrote:
> Hi,
>
> On 02/25/2011 02:36 PM, Ronald S. Bultje wrote:
>> ---
>>   libavformat/movenc.c |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 93d6ce9..57a6d11 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -1241,16 +1241,16 @@ static int mov_write_tapt_tag(ByteIOContext *pb, MOVTrack *track)
>>       int64_t pos = url_ftell(pb);
>>
>>       avio_wb32(pb, 0); /* size */
>> -    put_tag(pb, "tapt");
>> +    ffio_wfourcc(pb, "tapt");
>>
>>       avio_wb32(pb, 20);
>> -    put_tag(pb, "clef");
>> +    ffio_wfourcc(pb, "clef");
>>       avio_wb32(pb, 0);
>>       avio_wb32(pb, width<<  16);
>>       avio_wb32(pb, track->enc->height<<  16);
>>
>>       avio_wb32(pb, 20);
>> -    put_tag(pb, "enof");
>> +    ffio_wfourcc(pb, "enof");
>>       avio_wb32(pb, 0);
>>       avio_wb32(pb, track->enc->width<<  16);
>>       avio_wb32(pb, track->enc->height<<  16);
>
> This name is extremely ugly.

yes, the API is also worse

put_tag() worked with things that had length different from 4
sane thing would have been to make it ffio_put_tag() with put_tag() API
I tried to participate in the renamings but after ronald asked if we shall
vote and i asked for a vote ...
Anyone remembers being asked? a vote?
no, well, thats why i gave up. a vote amongt 4 hand picked people of the new
team on IRC is pointless. Thats not a vote

I can just offer that ffmpeg at videolan could provide an alternative API while
maintaining compatibility to this mess until the ronald/mans fork died.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110226/951112eb/attachment.pgp>



More information about the ffmpeg-devel mailing list