[FFmpeg-devel] [PATCH] configure: add check for pkg-config return value

Luca Barbato lu_zero
Mon Feb 28 13:24:48 CET 2011


On 02/28/2011 12:02 PM, Stefano Sabatini wrote:
> On date Thursday 2011-02-24 22:36:27 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>>
>>> Add check_pkgconfig_flags() function. This ensures that the result of
>>> pkg-config is correct. Avoid spurious success during configuration,
>>> which may lead to compilation errors.
>>>
>>> In particular prevents the compilation error I was getting with
>>> --enable-librtmp --enable-libopencv, which was due to a missing
>>> libssl.
>>> ---
>>>  configure |   15 +++++++++++----
>>>  1 files changed, 11 insertions(+), 4 deletions(-)
>>
>> This is more convoluted than it needs to be.  I'd also like to know
>> exactly why the link test didn't fail for you before adding workarounds.
> 
> Simplified and updated.

Probably could be useful factor the code so it behaves like the sdl one

if pkg-config $foo --exists;
then
	add_cflags ...
	...
fi

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero




More information about the ffmpeg-devel mailing list