[FFmpeg-devel] [PATCH] fix for roundup issue 2471

Michael Niedermayer michaelni
Mon Jan 3 03:04:38 CET 2011


On Sun, Jan 02, 2011 at 11:55:25PM +0100, Aurelien Jacobs wrote:
> On Sat, Jan 01, 2011 at 03:26:15PM -0500, Daniel Kang wrote:
> > I am a Google Code-In student and as part of a task, I have used zzuf to
> > generate a file that crashes ffmpeg. The issue is caused by invalid mkv
> > timestamps.
> > 
> > The patch attached fixes roundup issue 2471. It adds a sanity check
> > before incrementing the timestamp.
> 
> I don't think it's the proper place to fix this issue.
> Attached patch should fix the root of this issue.
> 
> Currently, the mpeg4video decoder corretly detects when time_base.den is
> null and error out, but it leaves time_base.num with it's non-null
> value. My patch just reset time_base.num to 0 before erroring out.
> 
> Aurel
>  mpeg4videodec.c |    1 +
>  1 file changed, 1 insertion(+)
> 57a9c667c1692e51a7dc69fbdf917967f09f7027  m4vdec_issue2471.diff

thats a possible fix yes, ok with me if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110103/19001b71/attachment.pgp>



More information about the ffmpeg-devel mailing list