[FFmpeg-devel] [PATCH] Clip-Wrapped MXF support (attempt #4)

Maksym Veremeyenko verem
Sun Jan 16 13:12:45 CET 2011


Reimar D?ffinger ???????(??):
> On Fri, Jan 14, 2011 at 10:14:27AM +0200, Maksym Veremeyenko wrote:
>>> But unless the specification actually _requires_ a complete index (which
>>> means it requires an index at all, and it requires that also each non-keyframe
>>> has an index entry) that is a solution that only works with "good luck", not
>>> properly.
>> First i am not sure that Clip-Wrapped files with
>> not-fixed-frames-size-content exists in real world - anyway we could
>> always test them and fix behavior of demuxer...
> 
> Have you tried MPEG-2 clip-wrapped (both audio and video) files?
No. I have no MPEG-2 clip-wrapped to try. All my clip-wrapped samples is 
  Panasonic P2 Camera created... And i am not sure it event exists for 
some reason...

> If your code is correct, you should be able to remove the
> st->need_parsing = AVSTREAM_PARSE_FULL;
> and it should still play. But I very much doubt it.
it will not play... For clip-wrapped files there are one video (or/and 
audio) chunk with data per file, so removing flag AVSTREAM_PARSE_FULL 
will make demuxer to read a full chunk instead of block from it...

>>> Does this code actually fix any case other that DV video? Because for DV it could be
>>> considered the real bug that the raw DV demuxer was not implemented using a parser
>>> (if it was, clip-wrapped DV should already work I think).
>> Hope it does not /fix/ anything other :-))) at least i did not noticed...
> 
> That makes it likely that your patch _only_ works for DV, and the question is
it works for AVC-intra too... i did not check against jpeg2000, but i 
suspect it will works too...


-- 
________________________________________
Maksym Veremeyenko



More information about the ffmpeg-devel mailing list