[FFmpeg-devel] [PATCH] Support Bandwidth header in RTSP requests

[Martin Storsjö]

On Wed, 19 Jan 2011, M?ns Rullg?rd wrote:

> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> 
> > Hi,
> >
> > On Tue, Nov 30, 2010 at 5:13 AM, John Wimer <john at god.vtic.net> wrote:
> >> This patch allows the Bandwidth header to be set in RTSP requests. This
> >> allows RTSP clients to specify the maximum bit rate that the RTSP server
> >> should stream to them.
> >>
> >> Refer to RFC 2326 section 12.6
> > [..]
> >> +++ b/libavformat/avformat.h
> >> @@ -787,6 +787,9 @@ typedef struct AVFormatContext {
> >>       */
> >>      int bit_rate;
> >>
> >> +    /* Maximum bitrate to request from rtsp server. */
> >> +    int max_bitrate;
> >> +
> >>      /* av_read_frame() support */
> >>      AVStream *cur_st;
> >>  #if FF_API_LAVF_UNUSED
> >
> > I don't think new entries should go into AVCodecContext, that's wrong
> > and will just bloat AVCodecContext into a massive unmaintainable mess.
> > Private codec options _could_ be considered for some cases.
> 
> This is AVFormatContext, but your point still stands.

Demuxer private options would be very welcome (we do have everything set 
up for muxer private options, but not for demuxers). I had a quick look on 
it some weeks ago, but it was less trivial than for muxers, due to the way 
demuxers are created, with probing and all that.

// Martin