[FFmpeg-devel] [PATCH] oggpagesize option added

[Janne Grunau]

On Thu, Jan 27, 2011 at 06:24:15PM +0100, Janne Grunau wrote:
> On Thu, Jan 27, 2011 at 09:30:05AM -0500, Ronald S. Bultje wrote:
> > Hi,
> > 
> > 2011/1/27 Andres Gonzalez <acandido at hi-iberia.es>:
> > > On 26/01/11 21:54, Baptiste Coudurier wrote:
> > >> You still have to buffer the page at segments_count == 255.
> > >
> > > Ok! Here it is.
> > [..]
> > > @@ -208,8 +227,9 @@ static int ogg_buffer_data(AVFormatContext *s, AVStream *st,
> > >          if (i == total_segments)
> > >              page->granule = granule;
> > >
> > > -        if (page->segments_count == 255) {
> > > -            ogg_buffer_page(s, oggstream);
> > > +        if(page->segments_count == 255 ||
> > > +           (ogg->pref_size > 0 && page->size >= ogg->pref_size)) {
> > > +           ogg_buffer_page(s, oggstream);
> > 
> > You broke the indent of that last line, should be 4-spaces not
> > 3-spaces. Still OK apart from that, whoever commits can fix that
> > himself...
> 
> and missing space between 'if' and '('. both fixed locally and queued

dropped in favour of the delay based solution

Janne