[FFmpeg-devel] [PATCH 1/2] Remove unneeded add bias from 3 functions.

Måns Rullgård mans
Sun Jan 30 19:20:56 CET 2011


Justin Ruggles <justin.ruggles at gmail.com> writes:

> On 01/27/2011 04:48 PM, Justin Ruggles wrote:
>
>> 
>> DSPContext.vector_fmul_window()
>> DCADSPContext.lfe_fir()
>> SynthFilterContext.synth_filter_float()
>> ---
>
>> --- a/libavcodec/ac3dec.c
>> +++ b/libavcodec/ac3dec.c
>> @@ -628,13 +628,15 @@ static inline void do_imdct(AC3DecodeContext *s, int channels)
>>              for(i=0; i<128; i++)
>>                  x[i] = s->transform_coeffs[ch][2*i];
>>              ff_imdct_half(&s->imdct_256, s->tmp_output, x);
>> -            s->dsp.vector_fmul_window(s->output[ch-1], s->delay[ch-1], s->tmp_output, s->window, 0, 128);
>> +            s->dsp.vector_fmul_window(s->output[ch-1], s->delay[ch-1], s->tmp_output, s->window, 128);
>>              for(i=0; i<128; i++)
>>                  x[i] = s->transform_coeffs[ch][2*i+1];
>>              ff_imdct_half(&s->imdct_256, s->delay[ch-1], x);
>>          } else {
>>              ff_imdct_half(&s->imdct_512, s->tmp_output, s->transform_coeffs[ch]);
>> -            s->dsp.vector_fmul_window(s->output[ch-1], s->delay[ch-1], s->tmp_output, s->window, 0, 128);
>> +            {START_TIMER
>> +            s->dsp.vector_fmul_window(s->output[ch-1], s->delay[ch-1], s->tmp_output, s->window, 128);
>> +            STOP_TIMER("vector_fmul_window")}
>>              memcpy(s->delay[ch-1], s->tmp_output+128, 128*sizeof(float));
>>          }
>>      }
>
> oops. START/STOP_TIMER obviously shouldn't be there.

Patch with ARM changes and without START/STOP_TIMER attached.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list