[FFmpeg-devel] [PATCH] av_get_delay

Michael Niedermayer michaelni at gmx.at
Fri Jul 1 06:46:47 CEST 2011


On Thu, Jun 30, 2011 at 08:03:39PM +0200, Nicolas George wrote:
[...]
> @@ -1518,6 +1521,22 @@ int av_interleave_packet_per_dts(AVFormatContext *s, AVPacket *out,
>   */
>  int av_write_trailer(AVFormatContext *s);
>  
> +/**
> + * Get timing information for the data currently output.
> + * The exact meaning of "currently output" depends on the format.
> + * It is mostly relevant for devices that have an internal buffer and/or
> + * work in real time.
> + * @param s       media file handle
> + * @param stream  stream in the media file

> + * @param dts     DTS of the last packet output for the stream
> + * @param wall    absolute time when that packet whas output

these should be marked as outputs
also the units/timebases used should be mentioned
otherwise the patchset LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110701/8daad44b/attachment.asc>


More information about the ffmpeg-devel mailing list