[FFmpeg-devel] [PATCH] lavfi: port boxblur filter from libmpcodecs

[Stefano Sabatini]

On date Monday 2011-07-11 12:08:42 +0200, Stefano Sabatini encoded:
> On date Monday 2011-07-11 02:10:34 +0200, Michael Niedermayer encoded:
> > On Sun, Jul 10, 2011 at 11:30:54PM +0200, Stefano Sabatini wrote:
> [...]
> > > > > As for the radius limit (radius < min(w/2,h/2)), what do you think is
> > > > > the best option?
> > > > > 
> > > > > 1. fail if the condition is not satisfied
> > > > > 2. clip radius in the valid range, and warn the user
> > > > > 3. make radius parametric, so you can tell radius=min(w/4,h/4)
> > > > 
> > > > a parametric radius is certainly a good idea
> > > > and radius > max(w,h) makes little sense as theres nothing left of the
> > > > picture at that point.
> > > > about min(w,h)/2, i think that may be annoying in corner cases
> > > > like when a image is 16x1024 sized for example, so it probably makes
> > > > sense to extend the code to handle values above that limit at some
> > > > point in the future.
> > > 
> > > also we may make horizontal/vertical radius configurable.
> > > 
> > > Anyway I don't see the need for adding even more features right now,
> > > new version attached.
> > 
> > yes, LGTM
> > and thx
> 
> Done some more minor changes in config_input(), I added the
> EVAL_RADIUS_EXPR macro, I'll apply soon if I see no more comments.

Pushed.
-- 
FFmpeg = Fostering and Fast MultiPurpose Exciting Guru