[FFmpeg-devel] [PATCH] pixcolorinfo: remove unused PixFmtInfo.depth field

Stefano Sabatini stefano.sabatini-lala at poste.it
Wed Jul 27 10:16:51 CEST 2011


On date Wednesday 2011-07-27 09:43:50 +0200, Michael Niedermayer encoded:
> On Wed, Jul 27, 2011 at 01:42:56AM +0200, Stefano Sabatini wrote:
> > On date Monday 2011-07-25 15:57:10 +0200, Michael Niedermayer encoded:
> > > On Mon, Jul 25, 2011 at 10:58:31AM +0200, Stefano Sabatini wrote:
> > [...]
> > > The problem is that if its made public (which the move would do)
> > > then nothing can be added or removed anymore
> > > i thus think the move is not a good idea
> > 
> > Can you elaborate on that? I don't want to make it public, being it
> > private changing the struct definition shouldn't hurt too much, since
> > it will only involve libavxxx > libavutil x.y.z dependencies.
> 
> libavcodec uses ff_pix_fmt_info after the patch that moves it to
> libavutil.

> thus if the table layout changes the same libavcodec would be
> incompatible with newer libavutil

Sure (I keep forgetting about this one...).

Can you suggest alternatives? I want to avoid to have to replicate the
same information in different libraries (libavfilter/libswscale).

Mostly I want to expose pixel format color information (global
colorspace and component color), a solution would require the use of
the preprocessor (but would imply object code duplication).
-- 
FFmpeg = Frightening & Foolish Mega Prodigious Erratic Genius


More information about the ffmpeg-devel mailing list