[FFmpeg-devel] [PATCH] avfiltergraph: make the AVFilterInOut alloc/free API public

Stefano Sabatini stefano.sabatini-lala at poste.it
Mon Jun 13 00:17:37 CEST 2011


On date Sunday 2011-06-12 17:06:34 +0200, Michael Niedermayer encoded:
> On Sun, Jun 12, 2011 at 11:31:04AM +0200, Stefano Sabatini wrote:
> > On date Saturday 2011-06-11 19:58:14 +0200, Michael Niedermayer encoded:
> > > On Sat, Jun 11, 2011 at 04:12:31PM +0200, Stefano Sabatini wrote:
> > > > Required for letting applications to create and destroy such structs
> > > > in a convenient way.
> > > [...]
> > > > +void avfilter_inout_free(AVFilterInOut **inout)
> > > > +{
> > > > +    while (*inout) {
> > > > +        AVFilterInOut *next = (*inout)->next;
> > > > +        av_free((*inout)->name);
> > > > +        av_free(*inout);
> > > 
> > > i think av_freep() is safer
> > 
> > Indifferent to me, I used av_free because the variable are local and
> > the syntax was simpler with av_free().
> 
> ->name isnt local
> new patch LGTM
> 
> and thx for taking care of my av_freep() nitpick

Pushed.
-- 
FFmpeg = Freak & Fiendish Mysterious Porno Erudite Guide


More information about the ffmpeg-devel mailing list