[FFmpeg-devel] [PATCH] lavfi: add vsink_buffer, and use it in ff* tools

[Stefano Sabatini]

On date Sunday 2011-06-12 17:32:37 +0200, Michael Niedermayer encoded:
> On Sun, Jun 12, 2011 at 11:37:58AM +0200, Stefano Sabatini wrote:
> >  cmdutils.c                 |   68 ---------------------------------
> >  cmdutils.h                 |   15 -------
> >  ffmpeg.c                   |   20 +++++----
> >  ffplay.c                   |   14 +++---
> >  libavfilter/Makefile       |    3 -
> >  libavfilter/allfilters.c   |    1 
> >  libavfilter/vsink_buffer.c |   91 +++++++++++++++++++++++++++++++++++++++++++++
> >  libavfilter/vsink_buffer.h |   49 ++++++++++++++++++++++++
> >  8 files changed, 163 insertions(+), 98 deletions(-)
> > e8eefb9a803b3afc8aef78bae1bc644a5a243c6f  0005-lavfi-add-vsink_buffer-and-use-it-in-ff-tools.patch
> > From e2dd12973690851926f2916c1e34d64a2722eb8a Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Sat, 11 Jun 2011 18:43:11 +0200
> > Subject: [PATCH] lavfi: add vsink_buffer, and use it in ff* tools
> > 
> > Also add the public interface libavfilter/vsink_buffer.h.
> 
> LGTM if tested

Not pushed, there is a small leak problem (when uniting the sink
inlink->cur_buf may still contain a picref, but inlink was already
freed. So we need either to unref the picref when freeing the link, or
cache the picref in the sink context, so we can free it in uninit) but
I'm too tired now to decide which is the better solution.

Patch updated with docs.
-- 
FFmpeg = Fascinating Fierce Majestic Porno Exxagerate Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-add-vsink_buffer-and-use-it-in-ff-tools.patch
Type: text/x-diff
Size: 17154 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110613/2937067a/attachment.bin>